Sunday, November 8, 2009

Code Review: Help yourself by helping your peers

After working a week on creating the command line interface for the Wattdepot project, we now begin a process called "Code Review". Our code review is an informal peer review consisting of peers examining each others source codes to find mistakes and possible improvements to their quality of their work, thus improving our own skills as a developer. We were each assign 2 other team's code to review. I will be doing my review on team "Umi" and "Umikumalua" codes which can be found here.

Team Umi:
Team Umi's system was well design with all commands working as intended. There were only a few minor error which could be easily fixed. Their javadocs were a bit brief but descriptive. One major thing they can work in is making test cases for each command. Here is my full review on Team Umi's system.

Team Umikumalua:
Team Umikumakahi's system competed most of the commands with a few not working as intended (chart, source summary). The javadoc were good but might have to work on some consistency between different authors. Things they can work on is making the remaining command work as intended, add more error messages, and make test cases for the commands. Here is my full review on Team UmiKumakahi's system.

0 comments:

Post a Comment